Merged
Conversation
The index template should be created by es-rollover. Without this, it was mandatory to use --es.create-index-templates=false with --es.use-ilm, otherwise it would override the index template with an empty lifecycle.name thus preventing the rollover to work Signed-off-by: Raphael Bizos <r.bizos@criteo.com>
Signed-off-by: Raphael Bizos <r.bizos@criteo.com>
Signed-off-by: Raphael Bizos <r.bizos@criteo.com>
Codecov Report
@@ Coverage Diff @@
## main #3610 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 264 264
Lines 15447 15449 +2
=======================================
+ Hits 14914 14916 +2
Misses 449 449
Partials 84 84
Continue to review full report at Codecov.
|
albertteoh
approved these changes
Apr 1, 2022
Contributor
|
Thanks! |
Contributor
Author
|
My pleasure, thanks for the review |
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
* useILM will prevent index template creation The index template should be created by es-rollover. Without this, it was mandatory to use --es.create-index-templates=false with --es.use-ilm, otherwise it would override the index template with an empty lifecycle.name thus preventing the rollover to work Signed-off-by: Raphael Bizos <r.bizos@criteo.com> * fixing ILM test Signed-off-by: Raphael Bizos <r.bizos@criteo.com> * Adding a comment for ILM and index creation Signed-off-by: Raphael Bizos <r.bizos@criteo.com> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clone of #3599 from another source branch to fix CI
Problem
With ILM, index patter overridden without lifecycle policy set by collector if not explicitly disabled with --es.create-index-templates=false
Proposal
Making useILM disable index creation to prevent this issue to happen