Skip to content

[fix test] Use file move instead of overwriting content#3726

Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro:fix-3702
Jun 3, 2022
Merged

[fix test] Use file move instead of overwriting content#3726
yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro:fix-3702

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

Resolves #3702 (hopefully)
Closes #3715

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 3, 2022 17:47
@yurishkuro yurishkuro requested a review from albertteoh June 3, 2022 17:47
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2022

Codecov Report

Merging #3726 (dc557fb) into main (2530903) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3726      +/-   ##
==========================================
+ Coverage   97.45%   97.48%   +0.02%     
==========================================
  Files         271      271              
  Lines       16023    16023              
==========================================
+ Hits        15616    15620       +4     
+ Misses        321      319       -2     
+ Partials       86       84       -2     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 98.20% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2530903...dc557fb. Read the comment docs.

@yurishkuro yurishkuro merged commit 9b41b8a into jaegertracing:main Jun 3, 2022
@yurishkuro yurishkuro deleted the fix-3702 branch June 3, 2022 17:56
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
…g#3726)

Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unstable test: TestHotReloadUIConfigTempFile

1 participant