Add support for the spanmetrics connector

[albertteoh]

Which problem is this PR solving?

Resolves #4345

Short description of the changes

• Adds support for spanmetrics connector via config parameters, while maintaining backwards compatibility with spanmetrics processor.
• Some quality of life changes added to help contributors with making changes to the SPM feature.

Testing

• Add test cases for connector case, and rely on existing tests to assert backwards compatibility.
• Manual testing via docker-compose to ensure both the service-level and operation-level metrics are visible in the Monitor tab.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (015020d) 97.05% compared to head (5dab4f5) 97.04%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4452      +/-   ##
==========================================
- Coverage   97.05%   97.04%   -0.02%     
==========================================
  Files         300      300              
  Lines       17740    17813      +73     
==========================================
+ Hits        17217    17286      +69     
- Misses        419      422       +3     
- Partials      104      105       +1     

Flag	Coverage Δ
unittests	97.04% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugin/metrics/prometheus/factory.go	100.00% <100.00%> (ø)
...trics/prometheus/metricsstore/dbmodel/to_domain.go	100.00% <100.00%> (ø)
plugin/metrics/prometheus/metricsstore/reader.go	100.00% <100.00%> (ø)
plugin/metrics/prometheus/options.go	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[albertteoh]

@yurishkuro please let me know if there's anything else that needs addressing in this PR.

[hdong69]

hi @albertteoh @yurishkuro. Are the changes included in all the images of Jaeger componets (agent, colector, query,....) version 1.45 ? If not, is any addional configuration needed to add ? Thanks

[albertteoh]

Are the changes included in all the images of Jaeger componets (agent, colector, query,....) version 1.45 ?

@hdong69 this change should be available from the next release (version 1.46.0), and is only relevant to jaeger all-in-one and jaeger-query components.

is any addional configuration needed to add ?

Please find instructions here: https://github.com/jaegertracing/jaeger/tree/main/docker-compose/monitor#migrating

[hdong69]

@albertteoh thanks for your feedback. so I understand that following the instruction (adding some variables in jaeger-query,...) could make the current version of jaeger query (jaegertracing/jaeger-query:1.45) works (curently, p95 doesnot appear in my Jaeger UI ) ? please correct me if i am wrong. thanks

[albertteoh]

so I understand that following the instruction (adding some variables in jaeger-query,...) could make the current version of jaeger query (jaegertracing/jaeger-query:1.45) works (curently, p95 doesnot appear in my Jaeger UI ) ?

Apologies, I wasn't clear. The instructions above only apply from version 1.46.

jaeger-query 1.45 will only work (for Latencies) with OTEL collector versions 0.70.0 and below. It was broken because of a change to the prometheusexporter in OTEL collector.

I'll create a PR that updates the v1.46 documentation to include these details.

[hdong69]

so I understand that following the instruction (adding some variables in jaeger-query,...) could make the current version of jaeger query (jaegertracing/jaeger-query:1.45) works (curently, p95 doesnot appear in my Jaeger UI ) ?

Apologies, I wasn't clear. The instructions above only apply from version 1.46.

jaeger-query 1.45 will only work (for Latencies) with OTEL collector versions 0.70.0 and below. It was broken because of a breaking change to the prometheusexporter in OTEL collector.

I'll create a PR that updates the v1.46 documentation to include these details.

okay i got it. Many thanks

[tmc]

Can we get a 1.46 release out?