Pass a wrapper instead of opentracing.Tracer to ease migration to OTEL in the future [part 1]#4529
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom Jun 14, 2023
Conversation
afzal442
force-pushed
the
refactor-opentracing-tracer
branch
from
c3cd998 to
baa4d94
Compare
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
overall looks reasonable, needs some cleanup. Next step would be passing the new struct deeper into components, to the point where it is actually used.
sbin64
force-pushed
the
refactor-opentracing-tracer
branch
from
baa4d94 to
b9afacc
Compare
afzal442
force-pushed
the
refactor-opentracing-tracer
branch
from
b9afacc to
95c6ccc
Compare
sbin64
changed the title
opentracing.Tracer interfaceopentracing.Tracer interface
sbin64
commented
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
yurishkuro
reviewed
Jun 13, 2023
afzal442
force-pushed
the
refactor-opentracing-tracer
branch
2 times, most recently
from
c27c6df to
f21068e
Compare
albertteoh
reviewed
Jun 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
==========================================
- Coverage 97.08% 97.05% -0.03%
==========================================
Files 300 301 +1
Lines 17813 17817 +4
==========================================
- Hits 17293 17292 -1
- Misses 417 421 +4
- Partials 103 104 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
afzal442
force-pushed
the
refactor-opentracing-tracer
branch
2 times, most recently
from
68fbd4b to
47b98e0
Compare
yurishkuro
previously approved these changes
Jun 14, 2023
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
lgtm, a couple minor cleanups and we should merge this.
Signed-off-by: afzal442 <afzal442@gmail.com>
afzal442
force-pushed
the
refactor-opentracing-tracer
branch
from
47b98e0 to
8420480
Compare
yurishkuro
approved these changes
Jun 14, 2023
yurishkuro
changed the title
opentracing.Tracer interfaceopentracing.Tracer to easy migration to OTEL in the future [part 1]
yurishkuro
changed the title
opentracing.Tracer to easy migration to OTEL in the future [part 1]opentracing.Tracer to ease migration to OTEL in the future [part 1]
kjschnei001
pushed a commit
to kjschnei001/jaeger
that referenced
this pull request
Jun 29, 2023
…TEL in the future [part 1] (jaegertracing#4529) ## Which problem is this PR solving? Part of jaegertracing#3381 ## Short description of the changes - This refactors the code by introducing a new wrapper object `JTracer` to wrap that interface Signed-off-by: afzal442 <afzal442@gmail.com> Signed-off-by: KevinSchneider <kevin.schneider@target.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Part of #3381
Short description of the changes
JTracerto wrap that interface