Add the enable tracing opt-in flag#4685
Merged
yurishkuro merged 2 commits intojaegertracing:mainfrom Aug 18, 2023
Merged
Conversation
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4685 +/- ##
==========================================
+ Coverage 97.02% 97.06% +0.03%
==========================================
Files 301 301
Lines 17878 17880 +2
==========================================
+ Hits 17347 17355 +8
+ Misses 425 421 -4
+ Partials 106 104 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
albertteoh
commented
Aug 18, 2023
Comment on lines
-111
to
+115
| server, err := app.NewServer(svc.Logger, queryService, metricsQueryService, queryOpts, tm, jtracer) | ||
| server, err := app.NewServer(svc.Logger, queryService, metricsQueryService, queryOpts, tm, jt) |
Contributor
Author
There was a problem hiding this comment.
Renamed to jt to avoid clashing names with the jtracer package.
| )) | ||
| }) | ||
|
|
||
| otel.SetTracerProvider(tracerProvider) |
Contributor
Author
There was a problem hiding this comment.
Moved here so we just set the global tracer in one place, and removes the otel dependencies from the respective files that use them.
I didn't see, or could think of, a use case where we wouldn't want to set the global tracer when instantiating a jtracer.
Let me know if that's not the case.
yurishkuro
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4680
Description of the changes
--query.enable-tracingto enable tracing for the jaeger-query component.How was this change tested?
Confirmed that
jaeger-queryis visible and contains traces:Checklist
- [] I have added unit tests for the new functionalityjaeger:make lint testjaeger-ui:yarn lintandyarn test