Skip to content

[hotrod] Move metrics endpoints from route to frontend service#4720

Merged
yurishkuro merged 3 commits intojaegertracing:mainfrom
yurishkuro:hotrod-move-metrics
Sep 4, 2023
Merged

[hotrod] Move metrics endpoints from route to frontend service#4720
yurishkuro merged 3 commits intojaegertracing:mainfrom
yurishkuro:hotrod-move-metrics

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

Which problem is this PR solving?

  • Previously, for unexplained reasons, the metrics endpoints (/metrics and /debug/expvar) in HotROD were served from the route service. That means 8083 port was also required to be exposed.

Description of the changes

  • Move metrics handlers to the frontend service
  • Return error from root service

How was this change tested?

$ curl http://0.0.0.0:8083/metrics
endpoint moved to the frontend service

@yurishkuro yurishkuro requested a review from a team as a code owner September 4, 2023 13:19
@yurishkuro yurishkuro requested a review from jkowall September 4, 2023 13:19
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro changed the title Hotrod move metrics [hotrod] Move metrics endpoints from route to frontend service Sep 4, 2023
@yurishkuro yurishkuro merged commit 0daccea into jaegertracing:main Sep 4, 2023
@yurishkuro yurishkuro deleted the hotrod-move-metrics branch September 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant