Replace python script with tracegen#4753
Merged
yurishkuro merged 4 commits intojaegertracing:mainfrom Sep 12, 2023
Merged
Conversation
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
albertteoh
commented
Sep 12, 2023
| docker run --env OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://otel_collector:4317" \ | ||
| --network monitor_backend \ | ||
| --rm \ | ||
| jaegertracing/jaeger-tracegen:1.49 \ |
Contributor
Author
There was a problem hiding this comment.
Let me know if there's a preference to use the latest tag.
yurishkuro
previously approved these changes
Sep 12, 2023
Member
|
you can also remove the respective section in .github/dependabot.yml |
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
albertteoh
commented
Sep 12, 2023
| - ${OTEL_CONFIG_SRC:-./otel-collector-config-connector.yml}:/etc/otelcol/otel-collector-config.yml | ||
| command: --config /etc/otelcol/otel-collector-config.yml | ||
| ports: | ||
| - "4317:4317" |
Contributor
Author
There was a problem hiding this comment.
Note that I've also removed this as we're executing tracegen in the same monitor_backend network. Tested this locally to make sure:
# Fail to access the port from host machine.
$ telnet localhost 4317
Trying 127.0.0.1...
telnet: Unable to connect to remote host: Connection refused
# Successfully write to port from docker command.
$ docker run --env OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://otel_collector:4317" \
--network monitor_backend \
--rm \
jaegertracing/jaeger-tracegen:1.49 \
-trace-exporter otlp-grpc \
-traces 1
...
2023-09-12T20:40:01.903Z LEVEL(-8) global/internal_logging.go:62 exporting spans {"count": 2, "total_dropped": 0}
Contributor
Author
Nice, thanks. Removed in: b850f02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
- [] I have added unit tests for the new functionalityjaeger:make lint testjaeger-ui:yarn lintandyarn test