ci: Split the install-tools into test/build groups#4878
Merged
yurishkuro merged 6 commits intojaegertracing:mainfrom Oct 24, 2023
Merged
ci: Split the install-tools into test/build groups#4878yurishkuro merged 6 commits intojaegertracing:mainfrom
yurishkuro merged 6 commits intojaegertracing:mainfrom
Conversation
yurishkuro
reviewed
Oct 21, 2023
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
Also call install test tools from two test workflows
yurishkuro
reviewed
Oct 22, 2023
Makefile
Outdated
| $(GO) install github.com/vektra/mockery/v2@v2.14.0 | ||
| .PHONY: install-test-tools | ||
| install-test-tools: | ||
| $(GO) install github.com/vektra/mockery/v2@v2.14.0 |
Member
There was a problem hiding this comment.
Suggested change
| $(GO) install github.com/vektra/mockery/v2@v2.14.0 |
yurishkuro
reviewed
Oct 22, 2023
Member
|
Please make sure all commits are signed |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 5 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
yurishkuro
approved these changes
Oct 24, 2023
yurishkuro
added
the
changelog:ci
yurishkuro
changed the title
yurishkuro
changed the title
Member
|
Thanks! |
Contributor
Author
|
Thank you for your guidance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4846
Refactor CI installation process: split install-tools into mockery/testing/build sub-targets, divide install-ci into install-test-tools and install-build-tools