Remove custom GOCACHE location#4995
Merged
yurishkuro merged 2 commits intojaegertracing:mainfrom Dec 11, 2023
Merged
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
==========================================
- Coverage 95.63% 95.61% -0.02%
==========================================
Files 319 319
Lines 18786 18786
==========================================
- Hits 17966 17963 -3
- Misses 659 661 +2
- Partials 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
commented
Dec 11, 2023
| - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 | ||
|
|
||
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe | ||
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 |
Member
Author
There was a problem hiding this comment.
sometimes dependabot adds version at the end, but not everywhere. I wonder if adding it manually once will cause it to keep adding it.
yurishkuro
commented
Dec 11, 2023
| GOBUILD=GOCACHE=$(GOCACHE) CGO_ENABLED=0 installsuffix=cgo $(GO) build -trimpath | ||
| GOTEST_QUIET=GOCACHE=$(GOCACHE) $(GO) test $(RACE) | ||
| GOBUILD=CGO_ENABLED=0 installsuffix=cgo $(GO) build -trimpath | ||
| GOTEST_QUIET=$(GO) test $(RACE) |
Member
Author
There was a problem hiding this comment.
Don't know why we had this GOCACHE override in the first place, it's better to use the system's cache location.
jkowall
approved these changes
Dec 11, 2023
Contributor
jkowall
left a comment
jkowall
left a comment
There was a problem hiding this comment.
Looks good, if not we can always revert :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?