Remove support for gRPC-Plugin#5388
Merged
yurishkuro merged 12 commits intojaegertracing:mainfrom May 11, 2024
Merged
Conversation
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
yurishkuro
reviewed
Apr 25, 2024
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
yurishkuro
reviewed
Apr 25, 2024
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
- please delete code, not comment out
- changes look like in the right direction, but they don't compile
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
==========================================
+ Coverage 95.30% 95.51% +0.21%
==========================================
Files 334 331 -3
Lines 16231 16107 -124
==========================================
- Hits 15469 15385 -84
+ Misses 582 550 -32
+ Partials 180 172 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashutosh Srivastava <ashutosh3002@gmail.com>
h4shk4t
changed the title
yurishkuro
reviewed
Apr 30, 2024
yurishkuro
added
the
changelog:breaking-change
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
approved these changes
May 11, 2024
10 tasks
yurishkuro
changed the title
SOF3
reviewed
Jun 27, 2024
|
|
||
| // ServeWithGRPCServer creates a plugin configuration using the implementation of StoragePlugin and | ||
| // function to create grpcServer, and then serves it. | ||
| func ServeWithGRPCServer(services *shared.PluginServices, grpcServer func([]grpc.ServerOption) *grpc.Server, |
There was a problem hiding this comment.
Is this removing the sidecar model or removing grpc plugin in general? What is the new correct way to start a remote grpc server if the StorageGRPCPlugin is also removed?
Member
There was a problem hiding this comment.
Jaeger still supports and will support Remote Storage API. You can write your gRPC server however you wish, no dependency on the Jaeger code is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test