[v2] Change e2e jaeger-v2 binary log output to temp file#5431
Merged
yurishkuro merged 6 commits intojaegertracing:mainfrom May 8, 2024
Merged
[v2] Change e2e jaeger-v2 binary log output to temp file#5431yurishkuro merged 6 commits intojaegertracing:mainfrom
yurishkuro merged 6 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5431 +/- ##
==========================================
+ Coverage 94.60% 94.91% +0.30%
==========================================
Files 346 334 -12
Lines 16951 16230 -721
==========================================
- Hits 16037 15404 -633
+ Misses 712 648 -64
+ Partials 202 178 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
yurishkuro
reviewed
May 8, 2024
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
a few comments:
- since we're writing to files, there's no need to mix stdout and stderr anymore, we can write to two files and dump them separately
- I'd say you want to kill the process first, and then read & dump the log files
- I am curious if we could create a foldable section in the GH running output. Not sure if it will work when using
t.Logf, I assume the special annotation needs to be at the start of the line
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Contributor
Author
|
This is the output for the group section in my local, since the CI has passed all the tests and I'm not sure if this actually working. |
yurishkuro
approved these changes
May 8, 2024
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
yurishkuro
reviewed
May 8, 2024
| fmt.Printf("Jaeger-v2 error logs:\n%s", errLogs) | ||
| // End of Github Actions foldable section annotation. | ||
| fmt.Println("::endgroup::") | ||
| } |
Member
There was a problem hiding this comment.
perhaps it makes sense to configure codecov to ignore cmd/jaeger/internal/integration/
yurishkuro
approved these changes
May 8, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
docker logsif failed.How was this change tested?
STORAGE=grpc SPAN_STORAGE_TYPE=memory make jaeger-v2-storage-integration-testcommand with success and fail scenario.Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test