[v2] Remove temporary SkipBinaryAttrs flag from e2e tests #5436
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom May 11, 2024
Merged
[v2] Remove temporary SkipBinaryAttrs flag from e2e tests #5436yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro merged 1 commit intojaegertracing:mainfrom
Conversation
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5436 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 334 334
Lines 16233 16233
=======================================
Hits 15469 15469
Misses 583 583
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
STORAGE=grpc SPAN_STORAGE_TYPE=memory make jaeger-v2-storage-integration-testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test