Fix alpine image to 3.19.0#5454
Conversation
remove root_image and cert_image and all the references Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix alpine version to 3.19.0 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5454 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 331 331
Lines 16113 16113
=======================================
Hits 15383 15383
Misses 556 556
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
|
Probably need to make a fix to Instead it should be pointed to check the Docker file |
fixed lint errors Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
I think it should point to the Dockerfile in the debug |
|
Thanks! |
| ARG cert_image | ||
| ARG root_image | ||
| ARG cert_image=alpine:3.19.0 | ||
| ARG root_image=alpine:3.19.0 |
There was a problem hiding this comment.
dependabot doesn't seem to be able to handle this, it did not raise a PR to upgrade to 3.19.1
I think we need to remove these args altogether and define versions directly in the FROM directive. That dependabot should definitely support.
Which problem is this PR solving?
fixes: #5450
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test