Restore code coverage threshold back to 95%#5457
Merged
yurishkuro merged 5 commits intojaegertracing:mainfrom May 18, 2024
Merged
Restore code coverage threshold back to 95%#5457yurishkuro merged 5 commits intojaegertracing:mainfrom
yurishkuro merged 5 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Signed-off-by: Vamshi Maskuri <117595548+varshith257@users.noreply.github.com>
Signed-off-by: Vamshi Maskuri <117595548+varshith257@users.noreply.github.com>
Signed-off-by: Vamshi Maskuri <117595548+varshith257@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5457 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 331 331
Lines 16112 16112
=======================================
Hits 15382 15382
Misses 556 556
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@yurishkuro Can you PTAL at the Cassandra failing test? It's looks weird printing too many logs |
yurishkuro
approved these changes
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test