Remove args and depict the image in From directive#5465
Merged
yurishkuro merged 10 commits intojaegertracing:mainfrom May 20, 2024
Merged
Remove args and depict the image in From directive#5465yurishkuro merged 10 commits intojaegertracing:mainfrom
yurishkuro merged 10 commits intojaegertracing:mainfrom
Conversation
remove root_image and cert_image and all the references Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix alpine version to 3.19.0 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fixed lint errors Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Remove args and depict the image in From directive Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5465 +/- ##
===========================================
- Coverage 95.49% 37.94% -57.55%
===========================================
Files 331 160 -171
Lines 16121 8351 -7770
===========================================
- Hits 15395 3169 -12226
- Misses 554 4877 +4323
- Partials 172 305 +133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
Contributor
Author
yes, didnt see |
fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes: #5450
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test