Skip to content

Enable Lint Rule: unexported-naming#5511

Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom
FlamingSaint:lint-rule
Jun 3, 2024
Merged

Enable Lint Rule: unexported-naming#5511
yurishkuro merged 1 commit intojaegertracing:mainfrom
FlamingSaint:lint-rule

Conversation

@FlamingSaint
Copy link
Copy Markdown
Member

Which problem is this PR solving?

Description of the changes

  • Enabled unexported-naming in revive linter.
  • Changed local variables to start with lowercase letters.

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 3, 2024 02:06
@FlamingSaint FlamingSaint requested a review from jkowall June 3, 2024 02:06
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (fd1b39e) to head (9d44d49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5511   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         327      327           
  Lines       16012    16012           
=======================================
  Hits        15403    15403           
  Misses        435      435           
  Partials      174      174           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.43% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.43% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7-v1 18.88% <ø> (ø)
elasticsearch-8-v1 19.07% <ø> (ø)
elasticsearch-8-v2 19.08% <ø> (+0.01%) ⬆️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.78% <ø> (ø)
opensearch-1-v1 18.92% <ø> (ø)
opensearch-2-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2-v2 18.94% <ø> (ø)
unittests 93.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 3, 2024
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 3382a27 into jaegertracing:main Jun 3, 2024
@FlamingSaint FlamingSaint deleted the lint-rule branch June 3, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants