Skip to content

Enable Lint Rule: exported#5525

Merged
yurishkuro merged 3 commits intojaegertracing:mainfrom
FlamingSaint:linter_2
Jun 4, 2024
Merged

Enable Lint Rule: exported#5525
yurishkuro merged 3 commits intojaegertracing:mainfrom
FlamingSaint:linter_2

Conversation

@FlamingSaint
Copy link
Copy Markdown
Member

Which problem is this PR solving?

Description of the changes

  • Enabled exported in revive linter
  • Converted struct Config to ConfigurationV2
  • Converted struct DependencyStoreParams to Params
  • Converted struct SamplingStoreParams to Params

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 3, 2024 22:43
@FlamingSaint FlamingSaint requested a review from jkowall June 3, 2024 22:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (b295383) to head (8da1bcd).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5525       +/-   ##
===========================================
+ Coverage   54.24%   96.20%   +41.96%     
===========================================
  Files         161      327      +166     
  Lines        8369    16013     +7644     
===========================================
+ Hits         4540    15406    +10866     
+ Misses       3383      433     -2950     
+ Partials      446      174      -272     
Flag Coverage Δ
badger_v1 8.05% <0.00%> (ø)
badger_v2 1.93% <0.00%> (ø)
cassandra-3.x-v1 16.44% <0.00%> (ø)
cassandra-3.x-v2 1.85% <0.00%> (ø)
cassandra-4.x-v1 16.44% <0.00%> (ø)
cassandra-4.x-v2 1.85% <0.00%> (ø)
elasticsearch-7-v1 18.88% <83.33%> (-0.02%) ⬇️
elasticsearch-8-v1 19.07% <83.33%> (-0.02%) ⬇️
elasticsearch-8-v2 19.08% <83.33%> (+0.01%) ⬆️
grpc_v1 9.47% <16.66%> (-0.02%) ⬇️
grpc_v2 7.53% <0.00%> (ø)
kafka 9.78% <0.00%> (ø)
opensearch-1-v1 18.92% <83.33%> (-0.02%) ⬇️
opensearch-2-v1 18.94% <83.33%> (ø)
opensearch-2-v2 18.94% <83.33%> (+0.01%) ⬆️
unittests 94.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 3, 2024
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from yurishkuro June 3, 2024 23:18
@yurishkuro yurishkuro merged commit 7dea2db into jaegertracing:main Jun 4, 2024
@FlamingSaint FlamingSaint deleted the linter_2 branch June 5, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants