Only attach :latest tag to versioned images from main#5781
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom Jul 28, 2024
Merged
Only attach :latest tag to versioned images from main#5781yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro merged 1 commit intojaegertracing:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
==========================================
+ Coverage 96.45% 96.66% +0.21%
==========================================
Files 342 342
Lines 16519 16519
==========================================
+ Hits 15933 15968 +35
+ Misses 395 362 -33
+ Partials 191 189 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
yurishkuro
force-pushed
the
compute-tags-no-latest
branch
from
659bb43 to
73bdbcc
Compare
yurishkuro
force-pushed
the
compute-tags-no-latest
branch
from
73bdbcc to
51cfa7c
Compare
This was referenced Jul 28, 2024
yurishkuro
added a commit
that referenced
this pull request
Jul 28, 2024
## Which problem is this PR solving? - Resolves #5721 - The previous PR #5781 didn't quite work because we were still applying tags like `--tag docker.io/foo/bar` (without a version), which evidently leads Docker to treat them as `:latest`, which is exactly what we are trying to avoid for `main` branch ## Description of the changes - Remove usage of no-version tags `--tag docker.io/foo/bar` completely - Fix unit tests, make them stricter ## How was this change tested? - Unit tests Signed-off-by: Yuri Shkuro <github@ysh.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
jaegertracing/all-in-one:latestdoes not match the latest Docker versioned tag nor the latest git tag #5721Description of the changes
latesttag when on themainbranchlatestwhen on a semver tagHow was this change tested?