Skip to content

[jaeger-v2] Add validation and comments to memory storage config (#5925)#5925

Merged
yurishkuro merged 4 commits intojaegertracing:mainfrom
mahadzaryab1:memory-storage-v2
Sep 2, 2024
Merged

[jaeger-v2] Add validation and comments to memory storage config (#5925)#5925
yurishkuro merged 4 commits intojaegertracing:mainfrom
mahadzaryab1:memory-storage-v2

Conversation

@mahadzaryab1
Copy link
Copy Markdown
Collaborator

Which problem is this PR solving?

Description of the changes

  • Implemented Validate method for Configuration struct for memory storage
  • Created migration doc from v1 to v2

How was this change tested?

  • Added unit tests for the new method

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review September 2, 2024 19:14
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner September 2, 2024 19:14
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (7df6975) to head (c7a467a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5925      +/-   ##
==========================================
+ Coverage   96.81%   96.82%   +0.01%     
==========================================
  Files         343      344       +1     
  Lines       16528    16531       +3     
==========================================
+ Hits        16001    16006       +5     
+ Misses        340      339       -1     
+ Partials      187      186       -1     
Flag Coverage Δ
badger_v1 8.05% <0.00%> (-0.01%) ⬇️
badger_v2 1.82% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v1 16.61% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v2 1.75% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.61% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2 1.75% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.78% <0.00%> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.83% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.04% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.82% <0.00%> (+0.01%) ⬆️
grpc_v1 9.49% <0.00%> (+<0.01%) ⬆️
grpc_v2 7.15% <0.00%> (-0.01%) ⬇️
kafka-v1 9.74% <0.00%> (-0.01%) ⬇️
kafka-v2 1.82% <0.00%> (-0.01%) ⬇️
memory_v2 1.81% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.89% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v1 18.89% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v2 1.82% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.46% <0.00%> (-0.01%) ⬇️
unittests 95.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:experimental Change to an experimental part of the code label Sep 2, 2024
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro changed the title [jaeger-v2] Align Memory Storage Config With OTEL [jaeger-v2] Add validation and comments to memory storage config (#5925) Sep 2, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) September 2, 2024 21:36
@yurishkuro yurishkuro merged commit ad6af7a into jaegertracing:main Sep 2, 2024
@mahadzaryab1 mahadzaryab1 deleted the memory-storage-v2 branch September 28, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage changelog:experimental Change to an experimental part of the code v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[jaeger-v2] Align Memory Storage Config With OTEL

2 participants