[jaeger-v2] Add Validation And Comments to Badger Storage Config#5927
Merged
yurishkuro merged 10 commits intojaegertracing:mainfrom Sep 5, 2024
Merged
[jaeger-v2] Add Validation And Comments to Badger Storage Config#5927yurishkuro merged 10 commits intojaegertracing:mainfrom
yurishkuro merged 10 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
commented
Sep 2, 2024
Collaborator
Author
mahadzaryab1
left a comment
mahadzaryab1
left a comment
There was a problem hiding this comment.
couple of questions for reviewers
plugin/storage/badger/options.go
Outdated
| Ephemeral bool `mapstructure:"ephemeral"` | ||
| SyncWrites bool `mapstructure:"consistency"` | ||
| MaintenanceInterval time.Duration `mapstructure:"maintenance_interval"` | ||
| namespace string |
Collaborator
Author
There was a problem hiding this comment.
do we want to make this field configurable?
plugin/storage/badger/options.go
Outdated
Comment on lines
+29
to
+34
| // KeyDirectory is the directory in which the keys are stored. Ephemeral must be | ||
| // set to false for this configuration to take effect. | ||
| KeyDirectory string `mapstructure:"directory_key"` | ||
| // ValueDirectory is the directory in which the values should be stored. Ephemeral must be | ||
| // set to false for this configuration to take effect. | ||
| ValueDirectory string `mapstructure:"directory_value"` |
Collaborator
Author
There was a problem hiding this comment.
do we want to group these?
Member
There was a problem hiding this comment.
we could, e.g.
directories:
keys: ...
values: ...
dosubot
bot
added
area/storage
storage/badger
16 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5927 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 344 344
Lines 16530 16537 +7
=======================================
+ Hits 16003 16010 +7
Misses 340 340
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:experimental
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
reviewed
Sep 4, 2024
yurishkuro
reviewed
Sep 4, 2024
plugin/storage/badger/options.go
Outdated
| // SpanStore holds the amount of time that the span store data is stored. | ||
| // Once this duration has passed for a given key, span store data will | ||
| // no longer be accessible. | ||
| SpanStore time.Duration `mapstructure:"span_store"` |
Member
There was a problem hiding this comment.
Suggested change
| SpanStore time.Duration `mapstructure:"span_store"` | |
| Spans time.Duration `mapstructure:"spans"` |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Member
|
please resolve conflicts |
Signed-off-by: Mahad Zaryab <43658574+mahadzaryab1@users.noreply.github.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Collaborator
Author
done! |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
Sep 5, 2024
Member
|
One more thing we can do is combine Options and NamespaceConfig into a single struct Config. |
Collaborator
Author
|
@yurishkuro do we just want to get rid of |
Member
|
Yes, the separate Options struct now serves no purpose. |
Collaborator
Author
Opened PR at #5937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Validatemethod forNamespaceConfigurationstruct for the badger storageHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test