[feat] Deduplicate spans based upon their hashcode#6009
Merged
yurishkuro merged 19 commits intojaegertracing:mainfrom Sep 24, 2024
Merged
[feat] Deduplicate spans based upon their hashcode#6009yurishkuro merged 19 commits intojaegertracing:mainfrom
yurishkuro merged 19 commits intojaegertracing:mainfrom
Conversation
yurishkuro
reviewed
Sep 23, 2024
fd74590 to
888ca59
Compare
Contributor
Author
|
@yurishkuro as discussed! let me know if you want anything else changed |
fa8c498 to
8022f67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6009 +/- ##
===========================================
+ Coverage 51.48% 96.79% +45.31%
===========================================
Files 176 349 +173
Lines 8875 16582 +7707
===========================================
+ Hits 4569 16050 +11481
+ Misses 3863 343 -3520
+ Partials 443 189 -254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Sep 23, 2024
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
Contributor
Author
|
PTAL :D |
yurishkuro
reviewed
Sep 23, 2024
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
yurishkuro
approved these changes
Sep 24, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Chris Danis <cdanis@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Chris Danis <cdanis@gmail.com>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
yurishkuro
reviewed
Sep 24, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Chris Danis <cdanis@gmail.com>
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
auto-merge was automatically disabled
September 24, 2024 15:59
Head branch was pushed to by a user without write access
Contributor
Author
|
added additional tests because patch code coverage failed |
yurishkuro
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test