Add support for retrieving unadjusted/raw spans#615
Merged
yurishkuro merged 2 commits intomasterfrom Dec 23, 2017
Merged
Conversation
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
ghost
assigned
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
support-retrieving-unadjusted-spans
branch
from
6b5b0b0 to
b65226d
Compare
black-adder
approved these changes
Dec 23, 2017
Contributor
black-adder
left a comment
black-adder
left a comment
There was a problem hiding this comment.
This should be super useful for debugging purposes. Do you mind updating the PR description as to why this is useful for future me when I forget?
Signed-off-by: Yuri Shkuro <ys@uber.com>
Member
Author
Added an actual issue (I thought we had it already). Once you try it you'll never forget it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #617