K8s integration test for HotROD#6155
Merged
yurishkuro merged 9 commits intojaegertracing:mainfrom Nov 17, 2024
Merged
Conversation
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6155 +/- ##
==========================================
- Coverage 96.51% 96.47% -0.04%
==========================================
Files 354 354
Lines 20127 20127
==========================================
- Hits 19425 19418 -7
- Misses 518 524 +6
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Nov 3, 2024
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Contributor
Author
|
@yurishkuro I have made the necessary changes |
yurishkuro
reviewed
Nov 14, 2024
Member
|
needs a rebase |
Signed-off-by: chahat sagar <109112505+chahatsagarmain@users.noreply.github.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
approved these changes
Nov 17, 2024
Contributor
Author
|
@yurishkuro its waiting for hotrod v1 , hotrod v2 status , but the the passing checks are hotrod [docker , v1 ] , hotrod [docker , v2] , hotrod [k8s ,v1] , hotrod [k8s , v2] |
Member
|
Thanks. I updated branch protection rule to expect the new CI runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test