Skip to content

Use real metrics factory instead of NullFactory#6261

Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro:remove-null-factory
Nov 26, 2024
Merged

Use real metrics factory instead of NullFactory#6261
yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro:remove-null-factory

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

Which problem is this PR solving?

  • Some components were still using metrics.NullFactory

Description of the changes

  • Create real factory from OTEL MetricsProvider

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (600d82c) to head (50b1922).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6261      +/-   ##
==========================================
- Coverage   96.44%   96.41%   -0.03%     
==========================================
  Files         355      355              
  Lines       20155    20156       +1     
==========================================
- Hits        19438    19434       -4     
- Misses        528      532       +4     
- Partials      189      190       +1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.67% <ø> (+<0.01%) ⬆️
grpc_v1 9.43% <ø> (-0.01%) ⬇️
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.33% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 16e964d into jaegertracing:main Nov 26, 2024
@yurishkuro yurishkuro deleted the remove-null-factory branch November 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants