feat: Add esmapping-generator into jaeger binary#6327
Merged
yurishkuro merged 5 commits intojaegertracing:mainfrom Jan 23, 2025
Merged
feat: Add esmapping-generator into jaeger binary#6327yurishkuro merged 5 commits intojaegertracing:mainfrom
yurishkuro merged 5 commits intojaegertracing:mainfrom
Conversation
Contributor
Author
|
@yurishkuro I think now this is perfectly decoupling the logic for generation in tool and then calling it from jaeger binary. Looking forward to your suggestions! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6327 +/- ##
==========================================
- Coverage 96.23% 96.23% -0.01%
==========================================
Files 373 377 +4
Lines 21406 21421 +15
==========================================
+ Hits 20600 20614 +14
Misses 614 614
- Partials 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jan 10, 2025
5 tasks
Rohanraj123
force-pushed
the
esmapping
branch
from
24c7af6 to
01ad9bc
Compare
yurishkuro
reviewed
Jan 11, 2025
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
how is a user expected to run this?
Rohanraj123
force-pushed
the
esmapping
branch
from
01ad9bc to
be85f38
Compare
yurishkuro
reviewed
Jan 12, 2025
yurishkuro
reviewed
Jan 15, 2025
yurishkuro
reviewed
Jan 16, 2025
yurishkuro
reviewed
Jan 16, 2025
yurishkuro
reviewed
Jan 16, 2025
yurishkuro
reviewed
Jan 19, 2025
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
lgtm overall, but some cleanup required
Rohanraj123
force-pushed
the
esmapping
branch
from
f2e79fb to
5568b42
Compare
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
Rohanraj123
force-pushed
the
esmapping
branch
from
5568b42 to
1769154
Compare
yurishkuro
reviewed
Jan 20, 2025
| "github.com/jaegertracing/jaeger/cmd/esmapping-generator/generator" | ||
| ) | ||
|
|
||
| func Command(options app.Options) *cobra.Command { |
Member
There was a problem hiding this comment.
Why do you need options as argument? It seems it's always passed as zero value
Contributor
Author
There was a problem hiding this comment.
For testing purpose.
Member
There was a problem hiding this comment.
it's not used in any way in tests. You set the params by passing CLI flags.
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
yurishkuro
approved these changes
Jan 23, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test