[ci] Scrape and verify metrics at the end of e2e tests#6330
Merged
yurishkuro merged 63 commits intojaegertracing:mainfrom Jan 16, 2025
Merged
[ci] Scrape and verify metrics at the end of e2e tests#6330yurishkuro merged 63 commits intojaegertracing:mainfrom
yurishkuro merged 63 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6330 +/- ##
==========================================
- Coverage 96.26% 96.21% -0.06%
==========================================
Files 372 372
Lines 21371 21371
==========================================
- Hits 20573 20562 -11
- Misses 608 616 +8
- Partials 190 193 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
chahatsagarmain
changed the title
yurishkuro
reviewed
Dec 9, 2024
yurishkuro
reviewed
Dec 9, 2024
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Dec 9, 2024
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Dec 14, 2024
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Dec 14, 2024
yurishkuro
reviewed
Dec 14, 2024
yurishkuro
reviewed
Dec 14, 2024
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Dec 15, 2024
yurishkuro
reviewed
Dec 15, 2024
yurishkuro
reviewed
Dec 15, 2024
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahat sagar <109112505+chahatsagarmain@users.noreply.github.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Jan 13, 2025
| if: github.ref_name == 'main' | ||
| shell: bash | ||
| run: | | ||
| mv ./.metrics/${{ inputs.snapshot }} ./.metrics/release_${{ inputs.snapshot}} |
Member
There was a problem hiding this comment.
We changed the meaning of this cache items, it's no longer "release" snapshot. We can call it baseline_*
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
… into e2e-metrics Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Jan 13, 2025
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
… into e2e-metrics Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Jan 15, 2025
yurishkuro
reviewed
Jan 15, 2025
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
any idea why the log mentions the name twice?
Cache not found for input keys: badger-metrics-v2.txt, badger-metrics-v2.txt
Contributor
Author
|
@yurishkuro I guess its the exact key that needs to be matched followed by restore key . |
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Jan 16, 2025
Comment on lines
+15
to
+17
| cache_key: | ||
| description: 'Cache key used for uploading and fetching the correct cached metric' | ||
| required: true |
Member
There was a problem hiding this comment.
Suggested change
| cache_key: | |
| description: 'Cache key used for uploading and fetching the correct cached metric' | |
| required: true |
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Jan 16, 2025
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
approved these changes
Jan 16, 2025
yurishkuro
changed the title
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 21, 2025
…#6330) ## Which problem is this PR solving? - Part of jaegertracing#6278 ## Description of the changes - scrape script and usage in cit workflow - diff calculating script - cache save and restore from main workflow runs - A sample diff (txt) ``` --- +++ @@ -303,2 +303,2 @@ -rpc_server_requests_per_rpc{le="+Inf",rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TestService",rpc_system="grpc",service_name="jaeger",service_version=""} -rpc_server_requests_per_rpc{le="0",rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="jaeger",service_version=""} +rpc_server_requests_per_rpc{le="+Inf",rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="jaeger",service_version=""} +rpc_server_requests_per_rpc{le="0",rpc_grpc_status_code="1",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="jaeger",service_version=""} @@ -321 +321 @@ -rpc_server_response_size{le="+Inf",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="jaeger",service_version=""} +rpc_server_response_size{le="+Inf",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="jaeger",service_version="",test_change="Export"} @@ -338 +338 @@ -rpc_server_response_size{rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="jaeger",service_version=""} +rpc_server_response_size{rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_name="test-jaeger",service_version=""} ``` ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> Signed-off-by: chahat sagar <109112505+chahatsagarmain@users.noreply.github.com> Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test