Enable UDP ports in all-in-one#6413
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom Dec 25, 2024
Merged
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6413 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 368 368
Lines 20979 20979
=======================================
Hits 20196 20196
Misses 599 599
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added a commit
to jaegertracing/documentation
that referenced
this pull request
Dec 25, 2024
Follow-up to jaegertracing/jaeger#6413 Signed-off-by: Yuri Shkuro <github@ysh.us>
mahadzaryab1
approved these changes
Dec 25, 2024
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
## Which problem is this PR solving? - Recently there was a thread in `#jaeger` slack room with a user who is still using legacy SDKs that emit traces via UDP. The all-in-one configuration in Jaeger v2 currently has them disabled, which breaks backwards compatibility. ## Description of the changes - Enable UDP ports ## How was this change tested? - Ran `go run ./cmd/jaeger` to ensure configuration is accepted. The user on slack also confirmed that it worked for them. - Unfortunately, we do not have e2e tests for this. Signed-off-by: Yuri Shkuro <github@ysh.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#jaegerslack room with a user who is still using legacy SDKs that emit traces via UDP. The all-in-one configuration in Jaeger v2 currently has them disabled, which breaks backwards compatibility.Description of the changes
How was this change tested?
go run ./cmd/jaegerto ensure configuration is accepted. The user on slack also confirmed that it worked for them.