Switch v1 receivers to use v2 write path#6532
Merged
yurishkuro merged 11 commits intojaegertracing:mainfrom Jan 15, 2025
Merged
Switch v1 receivers to use v2 write path#6532yurishkuro merged 11 commits intojaegertracing:mainfrom
yurishkuro merged 11 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6532 +/- ##
==========================================
+ Coverage 96.21% 96.23% +0.02%
==========================================
Files 372 372
Lines 21363 21371 +8
==========================================
+ Hits 20554 20567 +13
+ Misses 616 612 -4
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mahadzaryab1
approved these changes
Jan 15, 2025
| func TestConsumerHelper_Consume_Error(t *testing.T) { | ||
| consumerHelper := &consumerHelper{ | ||
| batchConsumer: newBatchConsumer(zaptest.NewLogger(t), | ||
| &mockSpanProcessor{expectedError: errors.New("mock error")}, |
Collaborator
There was a problem hiding this comment.
nit: can leverage assert.AnError here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
ptrace.Tracesobject is being received by the SpanProcessor.How was this change tested?
good-first-issueAdd e2e unit test for OTLP receiver in jaeger-v1 #6535 to add e2e tests after this