Pass Context through span processors#6534
Merged
yurishkuro merged 2 commits intojaegertracing:mainfrom Jan 13, 2025
Merged
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6534 +/- ##
==========================================
+ Coverage 96.21% 96.23% +0.02%
==========================================
Files 372 372
Lines 21360 21360
==========================================
+ Hits 20551 20556 +5
+ Misses 616 612 -4
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mahadzaryab1
approved these changes
Jan 13, 2025
| } | ||
|
|
||
| func (sp *spanProcessor) processSpans(batch processor.Batch, spans []*model.Span) ([]bool, error) { | ||
| func (sp *spanProcessor) processSpans(_ context.Context, batch processor.Batch, spans []*model.Span) ([]bool, error) { |
Collaborator
There was a problem hiding this comment.
just curious - why are we passing the context in here if its not being used?
Member
Author
There was a problem hiding this comment.
better have it and not need it
Signed-off-by: Yuri Shkuro <github@ysh.us>
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this pull request
Jan 14, 2025
## Which problem is this PR solving? - Context is lost in the process, see jaegertracing#6491 (comment) ## Description of the changes - Add Context argument to handler and span processor methods ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?