Skip to content

Return 400 instead of 500 on incorrect OTLP payload #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 10 commits into from
Jan 25, 2025
Merged

Return 400 instead of 500 on incorrect OTLP payload #6599

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1932a2b
Return 400
ADI-ROXX Jan 23, 2025
48a1d6f
Added a new test
ADI-ROXX Jan 24, 2025
6c4b8e7
Remove binaries
ADI-ROXX Jan 24, 2025
69bf467
Regex code
ADI-ROXX Jan 24, 2025
18466d3
Lint
ADI-ROXX Jan 24, 2025
0a9b4f0
Directly check StatusCode
ADI-ROXX Jan 24, 2025
13652f4
require.NoError
ADI-ROXX Jan 25, 2025
c9e997d
simpify
yurishkuro Jan 25, 2025
4f63e86
Merge branch 'main' into statusCode
yurishkuro Jan 25, 2025
e5dae10
fix-errors
yurishkuro Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/query/app/http_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func (aH *APIHandler) transformOTLP(w http.ResponseWriter, r *http.Request) {
}

traces, err := otlp2traces(body)
if aH.handleError(w, err, http.StatusInternalServerError) {
if aH.handleError(w, err, http.StatusBadRequest) {
return
}

Expand Down
23 changes: 23 additions & 0 deletions cmd/query/app/http_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,29 @@ func TestTransformOTLPBadPayload(t *testing.T) {
}, querysvc.QueryServiceOptions{})
}

func TestBadOTLPReturns400(t *testing.T) {
withTestServer(t, func(ts *testServer) {
url := ts.server.URL + "/api/transform"
request := "Bad Payload"
buf := &bytes.Buffer{}
encoder := json.NewEncoder(buf)
if err := encoder.Encode(request); err != nil {
require.Error(t, err)
}
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err := encoder.Encode(request); err != nil {
require.Error(t, err)
}
require.NoError(t, encoder.Encode(request))

Copy link
Copy Markdown
Contributor Author

@ADI-ROXX ADI-ROXX Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in the latest commit.

Copy link
Copy Markdown
Member

@yurishkuro yurishkuro Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected you'd be able to pattern match on the suggestion and apply it consistently, not just to this line.

r, err := http.NewRequest(http.MethodPost, url, buf)
if err != nil {
require.Error(t, err)
}
r.Header.Add("Accept", "application/json")
resp, err := httpClient.Do(r)
if err != nil {
require.Error(t, err)
}
defer resp.Body.Close()
require.Equal(t, 400, resp.StatusCode)
}, querysvc.QueryServiceOptions{})
}

func TestGetMetricsSuccess(t *testing.T) {
mr := &metricsmocks.Reader{}
apiHandlerOptions := []HandlerOption{
Expand Down