Skip to content

[refactor] Use plain loops with iterators#6722

Merged
yurishkuro merged 2 commits intojaegertracing:mainfrom
yurishkuro:use-loops
Feb 13, 2025
Merged

[refactor] Use plain loops with iterators#6722
yurishkuro merged 2 commits intojaegertracing:mainfrom
yurishkuro:use-loops

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

Description of the changes

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (0bc62de) to head (ddfbbb4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6722      +/-   ##
==========================================
- Coverage   96.03%   96.03%   -0.01%     
==========================================
  Files         364      364              
  Lines       20691    20675      -16     
==========================================
- Hits        19871    19855      -16     
  Misses        626      626              
  Partials      194      194              
Flag Coverage Δ
badger_v1 9.76% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.81% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.81% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.15% <ø> (ø)
elasticsearch-7.x-v1 19.23% <ø> (ø)
elasticsearch-8.x-v1 19.40% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.81% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.13% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.28% <ø> (ø)
opensearch-2.x-v1 19.28% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review February 13, 2025 01:27
@yurishkuro yurishkuro requested a review from a team as a code owner February 13, 2025 01:27
@yurishkuro yurishkuro requested a review from jkowall February 13, 2025 01:27
@yurishkuro yurishkuro enabled auto-merge (squash) February 13, 2025 01:28
Copy link
Copy Markdown
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit 5182729 into jaegertracing:main Feb 13, 2025
@yurishkuro yurishkuro deleted the use-loops branch February 13, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants