Collect metrics from ES bulk service#688
Merged
pavolloffay merged 3 commits intojaegertracing:masterfrom Feb 8, 2018
Merged
Conversation
pavolloffay
requested review from
black-adder,
vprithvi and
yurishkuro
as code owners
ghost
assigned
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
bulk-metrics
branch
from
f6eb1ba to
5a8de97
Compare
yurishkuro
approved these changes
Feb 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #662
This is not sending bulk stats https://github.com/olivere/elastic/wiki/BulkProcessor#stats to our metrics but just emitting additional duration metrics. Bulk stats does not provide this duration metrics.