Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions internal/storage/v2/grpc/tracewriter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package grpc

import (
"context"
"fmt"

"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/collector/pdata/ptrace/ptraceotlp"
"google.golang.org/grpc"

"github.com/jaegertracing/jaeger/internal/storage/v2/api/tracestore"
)

var _ tracestore.Writer = (*TraceWriter)(nil)

type TraceWriter struct {
client ptraceotlp.GRPCClient
}

// NewTraceWriter creates a TraceWriter that exports traces to a remote gRPC storage server.
//
// The provided gRPC connection is used exclusively for sending trace data to the backend.
// To prevent recursive trace generation, this connection should not have instrumentation enabled.
func NewTraceWriter(conn *grpc.ClientConn) *TraceWriter {
return &TraceWriter{
client: ptraceotlp.NewGRPCClient(conn),
}
}

func (tw *TraceWriter) WriteTraces(ctx context.Context, td ptrace.Traces) error {
req := ptraceotlp.NewExportRequestFromTraces(td)
_, err := tw.client.Export(ctx, req)
if err != nil {
return fmt.Errorf("failed to export traces: %w", err)
}
return nil
}
90 changes: 90 additions & 0 deletions internal/storage/v2/grpc/tracewriter_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package grpc

import (
"context"
"net"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/collector/pdata/ptrace/ptraceotlp"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
)

type testWriterServer struct {
ptraceotlp.UnimplementedGRPCServer

err error
}

func (s *testWriterServer) Export(
context.Context,
ptraceotlp.ExportRequest,
) (ptraceotlp.ExportResponse, error) {
return ptraceotlp.NewExportResponse(), s.err
}

func startWriterServer(t *testing.T, testServer *testWriterServer) *grpc.ClientConn {
listener, err := net.Listen("tcp", ":0")
require.NoError(t, err)

server := grpc.NewServer()
ptraceotlp.RegisterGRPCServer(server, testServer)

go func() {
server.Serve(listener)
}()

conn, err := grpc.NewClient(
listener.Addr().String(),
grpc.WithTransportCredentials(insecure.NewCredentials()),
)
require.NoError(t, err)

t.Cleanup(
func() {
conn.Close()
server.Stop()
listener.Close()
},
)

return conn
}

func TestTraceWriter_WriteTraces(t *testing.T) {
tests := []struct {
name string
serverErr error
expectedErr string
}{
{
name: "no error",
},
{
name: "server error",
serverErr: assert.AnError,
expectedErr: "failed to export traces",
},
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
server := &testWriterServer{err: test.serverErr}
conn := startWriterServer(t, server)

writer := NewTraceWriter(conn)
err := writer.WriteTraces(context.Background(), ptrace.NewTraces())
if test.expectedErr == "" {
require.NoError(t, err)
} else {
require.ErrorContains(t, err, test.expectedErr)
}
})
}
}
Loading