Merged
Conversation
Signed-off-by: Denys Vitali <denys@denv.it>
yurishkuro
reviewed
Apr 25, 2025
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
Who is the audience for this? A regular user will not be profiling jaeger code, only someone who wants to make changes and already has access to source code and can build jaeger. I don't mind adding the extension to the binary, but I don't like enabling it automatically in all-in-one, potentially causing port conflicts that the user has no way of turning off. I would only add it to config.yaml which is not shipped as part of the jaeger binary.
Contributor
Author
|
Yes, good point, no need for this to be enabled by default. My use case (today) was to find out why Jaeger takes 30m to start when Badger is enabled - and the only way for me to debug this is to enable pprof. |
Member
|
let's move the config change from all-in-one to cmd/jaeger/config.yaml |
Signed-off-by: Denys Vitali <denys@denv.it>
Contributor
Author
|
Done. Wdyt? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7073 +/- ##
==========================================
+ Coverage 96.01% 96.02% +0.01%
==========================================
Files 355 355
Lines 20993 20995 +2
==========================================
+ Hits 20156 20161 +5
+ Misses 630 628 -2
+ Partials 207 206 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? Currently it's not possible to profile Jaeger. This makes it hard to find bugs, memory leaks or problems in the running application. It looks like this was somehow supported in Jaeger v1 (I found references there) and was mentioned in `config.yaml` - but it didn't work out of the box because the extension was missing. ## Description of the changes This PR adds the [pprof](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/pprofextension/README.md) ## How was this change tested? Using `all-in-one.yaml` and connecting to `localhost:17777` ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [ ] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Denys Vitali <denys@denv.it>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? Currently it's not possible to profile Jaeger. This makes it hard to find bugs, memory leaks or problems in the running application. It looks like this was somehow supported in Jaeger v1 (I found references there) and was mentioned in `config.yaml` - but it didn't work out of the box because the extension was missing. ## Description of the changes This PR adds the [pprof](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/pprofextension/README.md) ## How was this change tested? Using `all-in-one.yaml` and connecting to `localhost:17777` ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [ ] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Denys Vitali <denys@denv.it> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently it's not possible to profile Jaeger. This makes it hard to find bugs, memory leaks or problems in the running application. It looks like this was somehow supported in Jaeger v1 (I found references there) and was mentioned in
config.yaml- but it didn't work out of the box because the extension was missing.Description of the changes
This PR adds the pprof
How was this change tested?
Using
all-in-one.yamland connecting tolocalhost:17777Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test