[spm] Add opensearch option#7304
Conversation
|
After W4 has been done I will add docker-compose file and e2e test for opensearch too |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7304 +/- ##
==========================================
- Coverage 96.18% 96.17% -0.02%
==========================================
Files 377 377
Lines 22886 22898 +12
==========================================
+ Hits 22014 22023 +9
- Misses 657 659 +2
- Partials 215 216 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
left a comment
There was a problem hiding this comment.
are you expecting backend changes to support working with OS? I.e. does it need different query shapes / aggregation queries?
If not, let's add the e2e integration test to enable OS, otherwise this PR makes it available via config without actually verifying that it works.
|
Hi @yurishkuro, it makes sense to also add e2e test for os in this pr too. Originally I plan to add in the follow up pr, but I think it should be in this pr too! |
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
232159a to
e71ff65
Compare
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
|
Hi @yurishkuro, I have added e2e test for opensearch for this pr also. It's now good to go! Thanks for your support |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test