Add OpenSearch 3.x support#7356
Add OpenSearch 3.x support#7356yurishkuro merged 1 commit intojaegertracing:mainfrom Parship999:OpenSearch-3.x-support-to-Jaeger
Conversation
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7356 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 378 378
Lines 22999 23003 +4
=======================================
+ Hits 22189 22193 +4
Misses 613 613
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yurishkuro could you please review it? |
|
nice job! |
|
@jkowall changes like this make me want to drop ES support completely. Somehow OpenSearch can run on a 10y old driver, but ES requires major driver upgrade for every major version, as if it's so easy to do when a project wants to support more than one ES version. |
4d6ac93
| return 0, fmt.Errorf("invalid version format: %s", version[0]) | ||
| } | ||
| if strings.Contains(info.TagLine, "OpenSearch") && (major == 1 || major == 2) { | ||
| if strings.Contains(info.TagLine, "OpenSearch") && (major == 1 || major == 2 || major == 3) { |
There was a problem hiding this comment.
I think the condition should be just if strings.Contains(info.TagLine, "OpenSearch") { as every opensearch version only supports ES 7, otherwise when OpenSearch 4.x is released it will break again. In case OpenSearch 4.x supports ES 8 it would have to be added explicitly anyway.
|
@yurishkuro When will this code be released? thank you. |
Which problem is this PR solving?
Description of the changes
internal/storage/elasticsearch/config/config.gointernal/storage/elasticsearch/client/cluster_client.gointernal/storage/integration/elasticsearch_test.gocluster_client_test.goconfig_test.godocker-compose/opensearch/v3/docker-compose.ymlfor testing with OpenSearch 3.xHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test