Dockerize es-indices-clean script

[pavolloffay]

Resolves #740

Signed-off-by: Pavol Loffay ploffay@redhat.com

[pavolloffay]

bash is not in alpine

[pavolloffay]

never used

[coveralls]

Coverage remained the same at 100.0% when pulling 83c7a56 on pavolloffay:dockerize-clean-indices into 30d3e18 on jaegertracing:master.

[black-adder]

For what purpose? Is usability improved by running the script inside the container?

[pavolloffay]

How do you want to run it as cronjob without container? jaegertracing/jaeger-kubernetes#40

[isaachier]

Personally, LGTM. @black-adder isn't in the office this week. Maybe @vprithvi or @yurishkuro can give this a final look.

[yurishkuro]

1. the name of the Dockerhub repository might look better as (jaeger-)es-index-cleaner
2. the es_indices_clean.sh looks like an anti-pattern. It will run pip install inside the container every time, I think we should only do this once at build time. And there's no need to have a shell script in the first place since we're already running in a python container - just execute python with the .py file directly

[pavolloffay]

the name of the Dockerhub repository might look better as (jaeger-)es-index-cleaner

It uses the same naming convention as other images.

the es_indices_clean.sh looks like an anti-pattern.

Do you want to remove scrip altogether? I agree about pip.

[isaachier]

The script might be useful for users not on Kubernetes, but they should probably use a real cronjob or Jenkins, so IMO makes sense to delete it.

[yurishkuro]

the name of the Dockerhub repository might look better as (jaeger-)es-index-cleaner

It uses the same naming convention as other images.

There isn't really a convention. I I just think "es index cleaner" describes better what the image represents than "es indices clean".

The script might be useful for users not on Kubernetes, but they should probably use a real cronjob or Jenkins, so IMO makes sense to delete it.

The python script will still be available, I am just saying there's no reason for a shell script as well, especially because it does pip install, which is likely to fail depending on user permissions.

[pavolloffay]

There isn't really a convention. I I just think "es index cleaner" describes better what the image represents than "es indices clean".

that yes, I didn't read it properly. I thought you want to remove jaeger prefix :/. I will rename it

[pavolloffay]

@yurishkuro image has been renamed and shell script removed.