Skip to content

Tune create on custom index to not be created if it already exists.#782

Merged
yurishkuro merged 1 commit intojaegertracing:masterfrom
gregswift:not-exists
Apr 23, 2018
Merged

Tune create on custom index to not be created if it already exists.#782
yurishkuro merged 1 commit intojaegertracing:masterfrom
gregswift:not-exists

Conversation

@gregswift
Copy link
Copy Markdown
Contributor

@gregswift gregswift commented Apr 23, 2018

This prevents schema upgrades or re-executions from erroring.

Closes jaegertracing/jaeger-openshift#79

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 23, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 294c0fb on gregswift:not-exists into cfb68d6 on jaegertracing:master.

Copy link
Copy Markdown
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro
Copy link
Copy Markdown
Member

Please sign the commit, eg

git commit -s --amend

Then force push.

@gregswift
Copy link
Copy Markdown
Contributor Author

@jpkrohling signed

…his prevents schema upgrades or re-executions from erroring

Signed-off-by: Greg Swift <gregswift@gmail.com>
@gregswift
Copy link
Copy Markdown
Contributor Author

update: i used -S not -s.. fixed.

@yurishkuro yurishkuro merged commit ddaf483 into jaegertracing:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants