Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
There was a problem hiding this comment.
Pull request overview
Updates CI orchestrator logic intended to recognize dependency-update bots so their PRs can use the faster parallel CI path.
Changes:
- Modifies the
github.actorchecks used to detect Dependabot/Renovate PRs in.github/workflows/ci-orchestrator.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Parallel for known bots (dependency update automation) | ||
| if [[ "${{ github.actor }}" == "dependabot[bot]" || "${{ github.actor }}" == "renovate[bot]" ]]; then | ||
| if [[ "${{ github.actor }}" == "dependabot" || "${{ github.actor }}" == "renovate-bot" ]]; then |
There was a problem hiding this comment.
The bot actor strings here look incorrect for GitHub App bots. Dependabot PRs typically run with github.actor == 'dependabot[bot]' (and the workflows README documents dependabot[bot]/renovate[bot]), so switching to dependabot will prevent bot PRs from using parallel mode. Consider matching the actual actor values (e.g., dependabot[bot] and either renovate[bot] and/or renovate-bot depending on which account is used in this repo) to avoid silently changing CI behavior.
| if [[ "${{ github.actor }}" == "dependabot" || "${{ github.actor }}" == "renovate-bot" ]]; then | |
| if [[ "${{ github.actor }}" == "dependabot[bot]" || \ | |
| "${{ github.actor }}" == "renovate-bot" || \ | |
| "${{ github.actor }}" == "renovate[bot]" ]]; then |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8094 +/- ##
==========================================
+ Coverage 95.66% 95.69% +0.02%
==========================================
Files 317 317
Lines 16668 16668
==========================================
+ Hits 15946 15950 +4
+ Misses 570 567 -3
+ Partials 152 151 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yuri Shkuro <github@ysh.us>
No description provided.