Skip to content

Close span writer in standalone #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavolloffay merged 2 commits into from
Jun 11, 2018
Merged

Close span writer in standalone #863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce2707
Close span writer in standalone
pavolloffay Jun 8, 2018
e58dec7
fix fmt
pavolloffay Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/standalone/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package main

import (
"fmt"
"io"
"log"
"net"
"net/http"
Expand Down Expand Up @@ -130,6 +131,13 @@ func main() {

select {
case <-signalsChannel:
if closer, ok := spanWriter.(io.Closer); ok {
Copy link
Copy Markdown
Contributor

@black-adder black-adder Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about spanReader, dependencyReader, etc. might be easier to register everything that implements the io.Closer interface during initialization and iterate over them and close them

Copy link
Copy Markdown
Member Author

@pavolloffay pavolloffay Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readers don't implement closer. This is just port from collector main.

err := closer.Close()
if err != nil {
logger.Error("Failed to close span writer", zap.Error(err))
}
}

logger.Info("Jaeger Standalone is finishing")
}
return nil
Expand Down