Skip to content

ES storage: not logging requests on error#901

Merged
yurishkuro merged 1 commit intojaegertracing:masterfrom
tmszdmsk:ES-storage-not-logging-requests-on-error
Jun 30, 2018
Merged

ES storage: not logging requests on error#901
yurishkuro merged 1 commit intojaegertracing:masterfrom
tmszdmsk:ES-storage-not-logging-requests-on-error

Conversation

@tmszdmsk
Copy link
Copy Markdown
Contributor

@tmszdmsk tmszdmsk commented Jun 30, 2018

Which problem is this PR solving?

Short description of the changes

Signed-off-by: Tomasz Adamski <tomasz.adamski@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2018

Codecov Report

Merging #901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #901   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         126      126           
  Lines        6072     6072           
=======================================
  Hits         6070     6070           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2990c0...0f825d5. Read the comment docs.

Copy link
Copy Markdown
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro yurishkuro merged commit 2793aa8 into jaegertracing:master Jun 30, 2018
@tmszdmsk
Copy link
Copy Markdown
Contributor Author

@yurishkuro
np, I was thinking about adding information about #failed requests and #all requests. What do you think about that?

@tmszdmsk tmszdmsk deleted the ES-storage-not-logging-requests-on-error branch June 30, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants