Add option to print export information #1123
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option `-print-export-info` to print interresting information of export functions. For the moment it only prints the alignment of the arguments
MrDaiki
reviewed
Apr 25, 2025
| @@ -423,8 +423,9 @@ let pp_sprog ~debug pd asmOp fmt ((funcs, p_extra):('info, 'asm) Prog.sprog) = | |||
| let pp_opn = pp_opn pd asmOp in | |||
| let pp_var = pp_var ~debug in | |||
| let pp_f_extra fmt f_extra = | |||
| Format.fprintf fmt "(* @[<v>alignment = %s; stack size = %a + %a; max stack size = %a;@ max call depth = %a;@ saved register = @[%a@];@ saved stack = %a;@ return_addr = %a@] *)" | |||
| Format.fprintf fmt "(* @[<v>alignment = %s; argument alignment = [%a];@ stack size = %a + %a; max stack size = %a;@ max call depth = %a;@ saved register = @[%a@];@ saved stack = %a;@ return_addr = %a@] *)" | |||
There was a problem hiding this comment.
Wouldn't it be interesting to output data as a standard format (for example json) ?
There was a problem hiding this comment.
We have this PR that has been open for long, but we could not find a principled way to implement it.
There was a problem hiding this comment.
I've added an option to print the export information in JSON.
This new export prints alignment information for all arguments. Where the previous printer was limited to the relevant information (alignment <> 8) to make it easier to read.
MrDaiki
requested changes
Apr 25, 2025
…for export information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option
-print-export-infoto print interesting information of export functions.For the moment it only prints the alignment of the arguments for each exported function.