[Mosaic GPU] Fix bug in Tiling.remove_dimension.
#29844
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_777464189
branch
3 times, most recently
from
d61231f to
96f66a7
Compare
We forgot to update `last_tile_rank` when looping over tiles, which could lead to incorrect dimension offsets. PiperOrigin-RevId: 777473496
copybara-service
bot
force-pushed
the
test_777464189
branch
from
96f66a7 to
ee832c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic GPU] Fix bug in
Tiling.remove_dimension.We forgot to update
last_tile_rankwhen looping over tiles, which could leadto incorrect dimension offsets.