Conversation
for example: https://codepen.io/a_vasilev/pen/mBPOjL open and press "TAB"
|
thanks for the fix, but please modify jquery.terminal-src.js file (that's the source file - just copy paste the code to the same place) and create PR against devel branch (that one you can change by clicking edit). you can also run make to create output files, then you will be mark as contributor to output files as well. Also fix the indent it's 4 spaces more for the whole for statement, the travis didn't throw error because it check only src file, you can check by running (after modifing -src.js file): from terminal After indent fix you will have one line too long, the expected 90 characters eslint rule, so you need to make this line shorter: } else if (pushCandidate.toLowerCase() === currentChar.toLowerCase()) {you can fix that by changing names to And thanks again for the fix |
|
Thank`s. Should I create a new pull request? |
change var names
|
I've changed branch to devel. |
|
There was bug in your PR found in #361 there was needed break from outer for loop if push is false |
for example: https://codepen.io/a_vasilev/pen/mBPOjL
open and press "TAB"