Dockerfile and documentation #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkasberg
added a commit
to mkasberg/classifier-reborn
that referenced
this pull request
Oct 2, 2022
While working on Ruby 3 support several months ago, I noticed the [Dockerfile](https://github.com/jekyll/classifier-reborn/blob/c3e5a84c3e0915d20ab52f2b783703575584d4a2/Dockerfile) was really stale. I didn't immediately fix this at the time, but made a mental note to come back to it sometime. This Dockerfile is intended to be used for development. It was added in jekyll#104 (discussed in detail at jekyll#101). The documentation for using this is still available (and accurate) at https://jekyll.github.io/classifier-reborn/development#development-using-docker. classifier-reborn currently supports ruby 2.7, 3.0, and 3.1 (as you can see in `ci.yml`). Since we can only (easily) put one ruby version in the Dockerfile, using the most recent version made sense to me. Doing so means we have to use Numo instead of GSL since GSL isn't currently supported on Ruby 3.x.
mkasberg
added a commit
to mkasberg/classifier-reborn
that referenced
this pull request
Oct 2, 2022
While working on Ruby 3 support several months ago, I noticed the [Dockerfile](https://github.com/jekyll/classifier-reborn/blob/c3e5a84c3e0915d20ab52f2b783703575584d4a2/Dockerfile) was really stale. I didn't immediately fix this at the time, but made a mental note to come back to it sometime. This Dockerfile is intended to be used for development. It was added in jekyll#104 (discussed in detail at jekyll#101). The documentation for using this is still available (and accurate) at https://jekyll.github.io/classifier-reborn/development#development-using-docker. classifier-reborn currently supports ruby 2.7, 3.0, and 3.1 (as you can see in `ci.yml`). Since we can only (easily) put one ruby version in the Dockerfile, using the most recent version made sense to me. Doing so means we have to use Numo instead of GSL since GSL isn't currently supported on Ruby 3.x.
mkasberg
added a commit
to mkasberg/classifier-reborn
that referenced
this pull request
Oct 2, 2022
While working on Ruby 3 support several months ago, I noticed the [Dockerfile](https://github.com/jekyll/classifier-reborn/blob/c3e5a84c3e0915d20ab52f2b783703575584d4a2/Dockerfile) was really stale. I didn't immediately fix this at the time, but made a mental note to come back to it sometime. This Dockerfile is intended to be used for development. It was added in jekyll#104 (discussed in detail at jekyll#101). The documentation for using this is still available (and accurate) at https://jekyll.github.io/classifier-reborn/development#development-using-docker. classifier-reborn currently supports ruby 2.7, 3.0, and 3.1 (as you can see in `ci.yml`). Since we can only (easily) put one ruby version in the Dockerfile, using the most recent version made sense to me. Doing so means we have to use Numo instead of GSL since GSL isn't currently supported on Ruby 3.x. The `MAINTAINER` dockerfile instruction is deprecated, so I removed it. (It isn't necessary anyway on a Dockerfile that doesn't publish a build.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable building Docker images locally or setting up an automatic build on DockerHub. The documentation assumes that an automatic build is setup at jekyll/classifier-reborn as discussed in #101.