Skip to content

Highlight deep-linked log line #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Highlight deep-linked log line #833

merged 2 commits into from
Jun 6, 2025

Conversation

janfaracik
Copy link
Member

image

Closes #824

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@janfaracik janfaracik requested a review from a team as a code owner June 6, 2025 17:26
@janfaracik janfaracik mentioned this pull request Jun 6, 2025
Closed
felipecrs
felipecrs approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@felipecrs felipecrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome!

chrome_QmxQvdSK92.mp4

@janfaracik janfaracik added the enhancement New feature or request label Jun 6, 2025
@janfaracik janfaracik merged commit b991078 into jenkinsci:main Jun 6, 2025
17 checks passed
@janfaracik janfaracik deleted the Deep-linked-log-line-should-get-highlighted branch June 6, 2025 19:07
@mawinter69
Copy link

Not perfect. With a start-byte offset greater 0 the selected line ends up behind the info banner that there's more to see
image
It's only visible when the selected line is visible when one has scrolled to the end of the page.

@timja timja mentioned this pull request Jun 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecrs felipecrs felipecrs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deep-linked log line should get highlighted
3 participants
@janfaracik @mawinter69 @felipecrs