Skip to content

build artifacts on release draft#30

Merged
jflo merged 60 commits intomainfrom
gha_artifacts
Jan 4, 2024
Merged

build artifacts on release draft#30
jflo merged 60 commits intomainfrom
gha_artifacts

Conversation

@jflo
Copy link
Copy Markdown
Owner

@jflo jflo commented Dec 21, 2023

No description provided.

jflo added 30 commits December 15, 2023 18:28
@jflo
docker task cleanup
d9fa14e 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
update dockerfiles manually
a113044 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
use self hosted arm for now
2fd8855 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
orgs from env
7675262 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
don't run the whole shebang, i can't believe that actually worked on …
183c32a 
…a free runner

Signed-off-by: jflo <justin+github@florentine.us>
@jflo
return to process
a96a61b 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
touch
8a76328 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
can we make sure expected checks have passed?
5b6d09e 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
rename
ddd6bee 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
caveman debugging
ba318dd 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
yay javascript
11bc5e0 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
new version, new location
0ee22f1 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
most of those fields were wrong
e0f4b3e 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
use the class
f43f17d 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
still not finding checks
78bbcf6 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
still not finding checks
2a1e28f 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
turns out commit statuses are not free
16adc40 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
lintaaaaaar
6423b26 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
wrong version
c569830 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
it's a step not a jorb
ee9b295 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
adds permissions and granular failure status
b88c328 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
moar permissions
d301675 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
now we have statuses
cd7ed89 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
restore return value filter
151e584 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
check for failures too
8d878f3 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
abort on any failed or missing expected success
bd7b569 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
manages acceptance test status, no artifacts created without it
53fc196 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
LINTAAARRRR
c64d687 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
trigger tests on code changed after approved
5dbe5fd 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
pin called workflows to this branch for now
c61979f 
Signed-off-by: jflo <justin+github@florentine.us>
jflo added 9 commits December 20, 2023 19:12
@jflo
TRUTHY
fa4a457 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
typos
730d9c5 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
what even is in the context
47ab502 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
found approvals, but no statuses?
4799a92 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
getting kinda weird, ngl
de7e84c 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
idk about this syntax
2b18a4c 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
filter gets 'em all
e568ca5 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
no more per-step checks
a2ec27f 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
enabling ref/int tests
35a8cbb 
Signed-off-by: jflo <justin+github@florentine.us>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 21, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

jflo added 10 commits December 21, 2023 08:43
@jflo
switch to temurin
8e08b8e 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
non-approved pr shouldn't have run accept tests
ca6f6ec 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
effing javascript
ba495d0 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
do you even toString bro
c06ab8d 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
still hate javascript
18cc85e 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
logic sucks
d233ebc 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
logic sucks
0288172 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
why does it insist there is an approving review?
550af90 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
it's in teh conditional
5051aad 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
prechecks on all tests
23afcaa 
Signed-off-by: jflo <justin+github@florentine.us>
garyschulte
garyschulte reviewed Dec 21, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval in spirit at least

garyschulte
garyschulte approved these changes Dec 21, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@garyschulte garyschulte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
sprocket approved 🐾

jflo added 6 commits December 21, 2023 18:14
@jflo
missed some deps
326482d 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
child workflows will need check:write perms
c0078c5 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
disable docker unless manual
68867f6 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
bad object deref
240795f 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
remove checks, and assume to be run only from main
3196b02 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
lets build docker images
d27adf1 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo jflo merged commit 6a49cc1 into main Jan 4, 2024
jflo pushed a commit that referenced this pull request Sep 3, 2024
@fab-10
Introduce TransactionSelectionContext to pass data between selectors …
c029a9f 
…and plugin (#30)

* Introduce TransactionSelectionContext to pass data between selectors

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Use TransactionSelectionContext in all the methods of the plugin selector

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jflo @garyschulte