Skip to content

Gha docker#31

Merged
jflo merged 15 commits intomainfrom
gha_docker
Jan 9, 2024
Merged

Gha docker#31
jflo merged 15 commits intomainfrom
gha_docker

Conversation

@jflo
Copy link
Copy Markdown
Owner

@jflo jflo commented Jan 5, 2024

PR description

Fixed Issue(s)

jflo added 14 commits January 4, 2024 15:57
@jflo
needed org on image build, fixes platform pair
b369fcc 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
docker test needed an org too
6139eca 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
testDocker needs an env var
3c0d1eb 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
need to run on self hosted arm
fed55d4 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
order matters
3d30033 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
syntax matters
1d3d43e 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
don't rerun image build so often, and fix tag collisions
229e295 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
whoops wrong step
5731859 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
include git sha in docker naming
04728b1 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
no more manual sha256ing
cd1b5ba 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
new job for multi-arch manifest
b29cfe8 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
md5? really boomer?
b1611ce 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
whoops can't get sha till checkout
b801930 
Signed-off-by: jflo <justin+github@florentine.us>
@jflo
only need artifacts and docker images on release prep
cf32fae 
Signed-off-by: jflo <justin+github@florentine.us>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

garyschulte
garyschulte approved these changes Jan 5, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@jflo
filename already included
55a38d1 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo jflo merged commit 4fe2888 into main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jflo @garyschulte