prettier-plugin-java not working in prettier-vscode anymore

[furti]

Since the last version update (2.6.6) prettier-plugin-java can not be loaded by prettier-vscode (https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) anymore.

The culprit seems to be this change: 2e7a828
It changed the exports field in package.json and only includes "types" and "import". But the Vscode plugin tries to load the modules using require.resolve('prettier-plugin-java').
Node throws an exception No "exports" main defined in .../node_modules/prettier-plugin-java/package.json

Changing the exports to include a require element, fixes the problem.

"exports": {
    ".": {
      "types": "./index.d.ts",
      "import": "./dist/index.js",
      "require": "./dist/index.js"
    }
  }

[clementdessoude]

Hello @furti ! Thank you for raising this issue ! I tried to reproduce it this evening, but didn't managed to.

Can you provide some further information about your setup ? Are you working on Windows or Unix ? What version of VSCode and Prettier Extension do you have ?

Here is the sample I used to test the setup, and it seems working well (on MacOS, VSCode - Version: 1.96.3 (Universal), Prettier Extension - Version 11.0.0)

sample.zip

[furti]

Thanks for your quick response.

Are you working on Windows or Unix
Kinda both. I work in WSL. VScode is installed under Windows but started from WSL. But I also get the same results when starting VScode directly in Windows.

What version of VSCode and Prettier Extension do you have ?
Vscode in WSL has the following Version

Version: 1.96.3 (user setup)
Commit: 91fbdddc47bc9c09064bf7acf133d22631cbf083
Date: 2025-01-09T18:14:09.060Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631

Prettier Plugin has version

Identifier esbenp.prettier-vscode
Version 11.0.0
Last Updated 2024-09-05, 10:39:16

On Windows VScode is pretty old

Version: 1.78.2 (system setup)
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:39:26.248Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.22631
Sandboxed: No

When I try your sample I get the following Error when prettier is initialized for a java file.

["INFO" - 7:54:16 AM] Extension Name: esbenp.prettier-vscode.
["INFO" - 7:54:16 AM] Extension Version: 11.0.0.
["INFO" - 7:54:17 AM] Using config file at /home/<username>/playground/prettier-test/.prettierrc.yaml
["ERROR" - 7:54:17 AM] Error handling text editor change
["ERROR" - 7:54:17 AM] No "exports" main defined in /home/<username>/playground/prettier-test/node_modules/prettier-plugin-java/package.json
Error: No "exports" main defined in /home/<username>/playground/prettier-test/node_modules/prettier-plugin-java/package.json
    at exportsNotFound (node:internal/modules/esm/resolve:304:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:594:13)
    at resolveExports (node:internal/modules/cjs/loader:634:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:724:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1211:27)
    at Function.t._resolveFilename (file:///home/<username>/.vscode-server/bin/91fbdddc47bc9c09064bf7acf133d22631cbf083/out/vs/workbench/api/node/extensionHostProcess.js:167:22816)
    at Function.resolve (node:internal/modules/helpers:190:19)
    at n (/home/<username>/.vscode-server/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:140:24)
    at /home/<username>/.vscode-server/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:163:23
    at Array.map (<anonymous>)
    at t.resolveConfigPlugins (/home/<username>/.vscode-server/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:160:40)
    at t.ModuleResolver.resolveConfig (/home/<username>/.vscode-server/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:418:52)
    at t.default.getSelectors (/home/<username>/.vscode-server/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:630:29)
    at t.default.handleActiveTextEditorChanged (/home/<username>/.vscode-server/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:607:27)

I modified the vscode extension slightly to get the original error. Otherwise you would get a message "Error resolve node moudle prettier-plugin-java". That is not that helpful.
My modifications where to format the minified file, and throw the original exception in line 142:

1282: (e, t, r) => {
        "use strict";
        Object.defineProperty(t, "__esModule", { value: !0 }),
          (t.resolveConfigPlugins =
            t.resolveNodeModule =
            t.loadNodeModule =
            t.nodeModuleLoader =
              void 0);
        const s = r(6928);
        function o() {
          return require;
        }
        function n(e, t) {
          try {
            return o().resolve(e, t); // This is the problematic line
          } catch (t) {
            throw t; // Threw the original exception instead of the generic error message
            throw new Error(`Error resolve node module '${e}'`);
          }
        }

How do you configure vscode to use prettier for java formatting? I have the following in my settings.json otherwise the formatter of the java plugin would be used instead:

{
    "prettier.documentSelectors": ["**/*.java"],
   "[java]": {
      "editor.defaultFormatter": "esbenp.prettier-vscode"
   }
}

[jtkiesel]

I was able to reproduce this on macOS, and confirmed that downgrading to prettier-plugin-java 2.6.5 resolved the issue. I also confirmed that manually making @furti's fix to the prettier-plugin-java package.json in node_modules resolves the issue.

[clementdessoude]

Hi ! It might be related to the used node version or prettier extension version that use require on your setup and import in mine.

Could you try replacing the exports section from

"exports": {
    ".": {
      "types": "./index.d.ts",
      "import": "./dist/index.js",
      "require": "./dist/index.js"
    }
  }

to

  "exports": {
    "types": "./index.d.ts",
    "default": "./dist/index.js"
  },

and tell me if it solves also your issue ?

If it works, it might be a bit simpler than defining both require and import sections

[furti]

@clementdessoude sorry for my late reply. Updated to 2.6.7 now and can confirm that the fix

"exports": {
    "types": "./index.d.ts",
    "default": "./dist/index.js"
  },

works for me.

Thanks a lot for fixing this.