feature blame popup

[tablatronix]

Description

optional, button in popup to goto blame, or inline blame , or view on github.

https://github.com/repo/repo/blame/branch/file.ext#L385

[deathaxe]

How about the Git blame package? It allows to show the blame of each line via phantoms.

Nevertheless adding the inline blame to the diff popup might be a useful feature.

[tablatronix]

Ill check that out, I am assuming it will not cross branch compare so it will blame the working branch, which is not as helpful though.

[deathaxe]

Not sure what you expect but as you always see the content of the working tree's file in your editor git blame always shows the most recent commit that changed the file. I found arguments to specify the amount of time to go back looking for changes but not a certain branch or path of branches to compare against.

A blame popup in GitGutter would just show the result of git blame -Lx,y -- <filename>.

The issue with creating a popup for it is the question how to trigger the popup? Showing the popup when hovering the gutter area of a line will most likely result in the popup fighting against other plugins. The currently used methods to avoid it (protected_regions) would not work then as the blame popup would occupy each line which git blame returns a value for.

[tablatronix]

Yeah thats the thing, I was manually comparing across branches, then blaming the compare against file:line to get the commit of that change ( usually latest was good enough ), then looking at that entire commit with all the change in context, and decide if I could cherry pick it. So even getting just the commit for that line in the compare might be good enough.

I started thinking, I could do alot more I could just get the commit of this change right in front of me.

Is there a feature discussion on adding callouts? user callouts might be cool with tokens for %filename %line etc.

I would not implement this entire feature inline, or use another plugin, I would just add a blame button to the popup itself and have it either show in the popup the info, or always blame and show it in the popup at the bottom footer style or something.

( better if it could link to github, but that is a use case specific request, other svn users would not benefit )

Just the output of git blame, is good, but why would it need to be another popup ??

[r-stein]

The problem with integrating git blame into the popup is that the popup only appears on changed lines. Hence you would change the line to enable the popup and then press the git blame button to open the blame. This doesn't sound like a reasonable behavior.

[tablatronix]

Still not sure I see the problem, what do you mean "change the line" ?

The gutter already shows the change, the popup already exists, I want the blame on the compare against source , not the current file.

[r-stein]

Let's say you want to blame on line 34, but you didn't change the line. Then the git gutter popup won't appear on the line. Hence you need to change it to enable the popup and press the button.

[tablatronix]

I don't want to blame line 34. I want to blame the line that shows a change, and blame the other line...
If that makes any sense.

I guess ill make a gif or mockup

I guess this only makes sense on changes, not deletions or insertions

[r-stein]

If you only want to blame lines you have changed the button makes sense, but git blame is usually not only used on changed lines.

[tablatronix]

ah, Ok I should qualify that then

Blame the current line/change in the diff source, to get the commit of that diff in the source, source being the compare against source, which may depend on context of source (branch, commit, origin) for blame capability, but most should work.

[tablatronix]

Not sure this is even possible, now that I think about it...
Git blame probably only works on working tree..

doh,

EDIT , you can!

[deathaxe]

Do I understand correct?

You want to see the blame output of the content which is displayed within diff popup? So you can see who changed the line within the committed file you are currently comparing against?

[tablatronix]

Yeah I think that sounds about right.

This is just an example

[deathaxe]

If I read the git blame documentation correctly, specifying a branch name like "esp32" in your case just limits the range git blame walks back in history to look for changes. It does not specify the "esp32" to be the commit to take the source file to blame from.

With other words: Blame works for the working file only.

So what's possible is to call git blame against the changed lines of the working file (which are highlighted in the gutter area) to reveal the most recent commit the changes were introduced in. Your compare target might point to a commit which is much older and therefore changes are displayed which belong to different commits.

From this point of view some kind of "status line" at the bottom of the popup with the author, date and commit of that change might make sense. As a result a button could be added to set the compare target exactly to that commit.